Remove GlimmerX#716
Merged
wagenet merged 16 commits intotyped-ember:mainfrom Mar 21, 2024
Merged
Conversation
NullVoxPopuli
approved these changes
Mar 20, 2024
Contributor
|
Before merge, we should probably release the current stuff on main |
wagenet
approved these changes
Mar 21, 2024
11 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emberjs/rfcs#1014
Removes any reference of GlimmerX from Glint.
Justification from the RFC:
Notes
<template>tags within.gtsfiles) were first tested out via inlinehbstemplate tags in the glimmerx environment; in order to not lose test coverage, I did my best to convert these glimmerx test to .gts ember-template-import tests rather than wholesale removing them.